Skip to content

[SYCL] Strengthen split-with-func-ptrs.ll test. #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2022
Merged

[SYCL] Strengthen split-with-func-ptrs.ll test. #6481

merged 1 commit into from
Jul 28, 2022

Conversation

kbobrovs
Copy link
Contributor

Add a tescase which checks that the definition of a function called from an
address-taken function is also added to all split modules.

Signed-off-by: Konstantin S Bobrovsky [email protected]

@kbobrovs
[SYCL] Strengthen split-with-func-ptrs.ll test.
68b00b0 
Add a tescase which checks that the definition of a function called from an
address-taken function is also added to all split modules.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
@kbobrovs kbobrovs requested a review from a team as a code owner July 27, 2022 00:33
@kbobrovs
Copy link
Contributor Author

Failures are unrelated:
ESIMD Emu Failed Tests (3):
SYCL :: dpas/dpas_test1.cpp
SYCL :: dpas/dpas_test2.cpp
SYCL :: dpas/dpas_test3.cpp

HIP AMDGPU Failed Tests (1):
SYCL :: Basic/event_profiling_info.cpp

@kbobrovs kbobrovs requested a review from asudarsa July 27, 2022 17:22
asudarsa
asudarsa approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@asudarsa
Copy link
Contributor

Hi @kbobrovs
I think it might be a good idea to report the failures under a bug report. But it should not block merging.
Thanks

@pvchupin
Copy link
Contributor

dpas tests handled at intel/llvm-test-suite#1115
Please follow up with opening a hip issue.

@kbobrovs kbobrovs merged commit 3bf7d5c into intel:sycl Jul 28, 2022
@kbobrovs
Copy link
Contributor Author

Hi @kbobrovs I think it might be a good idea to report the failures under a bug report. But it should not block merging. Thanks

@asudarsa , done

@kbobrovs kbobrovs deleted the post-link-fptr-test-improve branch August 16, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudarsa asudarsa asudarsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbobrovs @asudarsa @pvchupin