[SYCL] Cache and reuse events in the Level Zero plugin. #6484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
5867
to
5869
| Event->Context->addZeEventToCache(Event->ZeEvent, Event->ZeEventPool, | ||
| Event->isHostVisible(), | ||
| Event->isProfilingEnabled()); |
There was a problem hiding this comment.
Can we maybe cache the PI event instead of re-creating from L0 components?
There was a problem hiding this comment.
Good call, thanks, fixed.
Avoid creating new Level Zero events. Reset native event handles and put them in the cache instead of removing.
againull
force-pushed
the
events_reuse_general_case
branch
from
8935550 to
95d1584
Compare
againull
changed the title
|
CUDA backend failures are unrelated. |
| @@ -276,6 +276,8 @@ template <class T> struct ZeCache : private T { | |||
| struct ReferenceCounter { | |||
| ReferenceCounter(pi_uint32 InitVal) : RefCount{InitVal} {} | |||
|
|
|||
| void reset(pi_uint32 InitVal) { RefCount = InitVal; } | |||
There was a problem hiding this comment.
this is strange that it takes an arbitrary integer (I think you only call it with "1")
why is this needed?
Hardcode initial value to 1 because ReferenceCounter is used only for ref counting pi_objects where initial value is always 1.
smaslov-intel
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating new pi_event objects. Reset pi_event objects
and put them in the cache instead of removing.