Skip to content

[SYCL][ext] Add always_inline attribute to round_to_tf32 #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Aug 5, 2022

This should have been defined with always inline to avoid multiple symbols in multi object compilations

@hdelan hdelan requested a review from a team as a code owner August 5, 2022 10:05
@hdelan hdelan requested a review from cperkinsintel August 5, 2022 10:05
@hdelan hdelan changed the title [SYCL][ext] Round to tf32 was missing always_inline attribute [SYCL][ext] Add always_inline attribute to round_to_tf32 Aug 5, 2022
@JackAKirk JackAKirk requested a review from dkhaldi September 1, 2022 09:14
@JackAKirk
Copy link
Contributor

@cperkinsintel would it be possible to get a review for this?
Thanks

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdelan
Copy link
Contributor Author

hdelan commented Sep 16, 2022

Thanks for review @dkhaldi . @bader can we merge this please?

@bader
Copy link
Contributor

bader commented Sep 16, 2022

@cperkinsintel, @intel/llvm-reviewers-runtime, ping.

@againull againull merged commit b5023ea into intel:sycl Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants