[SYCL][CUDA] Allow joint_matrix to be loaded from const T #6532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <[email protected]>
JackAKirk
changed the title
Signed-off-by: JackAKirk <[email protected]>
JackAKirk
changed the title
|
btw the CUDA test failure is the now XFAIL'ed known flaky test Assert/assert_in_simultaneously_multiple_tus.cpp |
|
ping @v-klochkov |
v-klochkov
reviewed
Sep 16, 2022
|
/verify with intel/llvm-test-suite#1280 |
|
/verify with intel/llvm-test-suite#1280 |
Thanks. I've added all new possible use cases in the test here: intel/llvm-test-suite#1280 |
v-klochkov
approved these changes
Sep 21, 2022
|
/verify with intel/llvm-test-suite#1280 |
|
Can this be merge now? |
pvchupin
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Oct 5, 2022
This tests new cases made possible in intel/llvm#6532, such that A,B, Accumulator accessors that are loaded to registers in joint_matrix can be of type const T.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…st-suite#1280) This tests new cases made possible in intel#6532, such that A,B, Accumulator accessors that are loaded to registers in joint_matrix can be of type const T.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if
joint_matrix_loadattempts to loadjoint_matrixfrom an array ofconst Tincorrect behaviour will occur or an error will be thrown. To fix this we make use ofstd::remove_const_t<T>in appropriate places. This is important functionality for integrating joint_matrix with existing SYCL-DNN routines.I think that similar problems might occur in the intel backends for their existing impl: I have not made corresponding changes because I do not have the hardware to test it.
Signed-off-by: JackAKirk [email protected]