Skip to content

[SYCL][ABI-break] Remove make_context and make_queue #6546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Aug 18, 2022
Merged

[SYCL][ABI-break] Remove make_context and make_queue #6546

merged 21 commits into from
Aug 18, 2022

Conversation

raaiq1
Copy link
Contributor

@raaiq1 raaiq1 commented Aug 9, 2022

Removed from L0 plugin:

  1. make_context(const std::vector &DeviceList, pi_native_handle NativeHandle)
  1. make_queue(const context &Context, pi_native_handle NativeHandle)

raaiq1 and others added 16 commits June 17, 2022 14:56
@raaiq1
Merge pull request #2 from intel/sycl
58ebf67 
v
@raaiq1
Merge pull request #5 from intel/sycl
6c85afe 
c
@raaiq1
Merge pull request #7 from intel/sycl
e13331b 
pull
@raaiq1
Merge branch 'intel:sycl' into sycl
8be9589
@raaiq1
Merge branch 'intel:sycl' into sycl
5d0f20e
@raaiq1
Merge branch 'intel:sycl' into sycl
35ff2e2
@raaiq1
Merge branch 'intel:sycl' into sycl
7ca6c3e
@raaiq1
Merge branch 'intel:sycl' into sycl
1e5f193
@raaiq1
Merge branch 'intel:sycl' into sycl
b310bb9
@raaiq1
Merge pull request #12 from intel/sycl
90c3232 
[SYCL][ABI-break] Remove kernel::get_work_group_info (intel#6414)
@raaiq1
Merge branch 'intel:sycl' into sycl
02b2ecb
@raaiq1
Merge branch 'sycl' of https://github.com/raaiq1/llvm into sycl
4f55f51
@raaiq1
Merge branch 'sycl' of https://github.com/raaiq1/llvm into sycl
307b805
@raaiq1
Merge branch 'sycl' of https://github.com/raaiq1/llvm into sycl
90461c8
@raaiq1
Merge branch 'sycl' of https://github.com/raaiq1/llvm into sycl
a82677e
@raaiq1
Merge branch 'sycl' of https://github.com/raaiq1/llvm into sycl
75b94dd
@raaiq1 raaiq1 requested a review from a team as a code owner August 9, 2022 17:25
@raaiq1 raaiq1 requested a review from v-klochkov August 9, 2022 17:25
@raaiq1 raaiq1 force-pushed the remove_make_context branch from 562c26d to aeacb2a Compare August 12, 2022 20:52
@v-klochkov
Copy link
Contributor

@smaslov-intel - can you please also take a look at this fix as the one who added make_context being removed here.

smaslov-intel
smaslov-intel approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raaiq1
Copy link
Contributor Author

raaiq1 commented Aug 16, 2022 •
edited
Loading

CI failures are unrelated to PR, failures change on CI re-runs

@againull againull merged commit 213c82c into intel:sycl Aug 18, 2022
@raaiq1 raaiq1 deleted the remove_make_context branch August 24, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raaiq1 @v-klochkov @smaslov-intel @againull