[SYCL] SYCL 2020 standalone device selectors ( gpu_selector_v and friends) #6549
Conversation
|
/verify with intel/llvm-test-suite#1141 |
Signed-off-by: Chris Perkins <[email protected]>
|
For some reason, when resolving the merge conflicts, there were only conflict in the linux abi .dump file, not the Windows one. Odd. I merged, rebuilt on both platforms, and reran the ABI symbols generation on both. The merge conflict is resolved, but on Windows my .dump has picked up the symbols from the recently merged #6474 for some reason. Maybe reordering? Maybe the symbols from 6474, while correct, weren't generated by the python script? |
|
/verify with intel/llvm-test-suite#1141 |
|
ping to reviewers. |
| // -------------- SYCL 2020 | ||
|
|
||
| // SYCL 2020 standalone selectors | ||
| __SYCL_EXPORT int default_selector_v(const device &dev); | ||
| __SYCL_EXPORT int gpu_selector_v(const device &dev); | ||
| __SYCL_EXPORT int cpu_selector_v(const device &dev); | ||
| __SYCL_EXPORT int accelerator_selector_v(const device &dev); | ||
|
|
There was a problem hiding this comment.
I think we should move it to the top of the file (as that's the most recent/modern interface and we want reader to get familiar with state of the art, not deprecated ways). After that, the section with old-style selectors above should be prefixed with a comment saying that they're remnants of SYCL 1.2.
Signed-off-by: Chris Perkins <[email protected]>
|
ping to reviewers and mergers. I have had to update this twice already because of linux symbol merge conflicts. My worry is that if it takes too long it'll get conflicted again. |
implementation of standalone selectors (e.g. gpu_selector_v, etc)
new tests for llvm-test-suite are here: intel/llvm-test-suite#1141