[SYCL][ABI-break] Promote extended CG/handler members #6555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several new members were added to CG/handler via the extended member workaround. This patch promotes them to actual fields of those classes now that the ABI can be broken.
|
I'm planning to remove the extended member mechanism in a separate follow-up PR, just so it would be easier to recover it if we need to add new members to CG classes in the future. |
|
@smaslov-intel Could you please review? |
| @@ -30,7 +30,7 @@ set(SYCL_MINOR_VERSION 7) | |||
| set(SYCL_PATCH_VERSION 0) | |||
| # Don't forget to re-enable sycl_symbols_windows.dump once we leave ABI-breaking | |||
| # window! | |||
| set(SYCL_DEV_ABI_VERSION 8) | |||
| set(SYCL_DEV_ABI_VERSION 9) | |||
There was a problem hiding this comment.
I think I saw this change already in another ABI breaking change today, so someone will get a conflict.
There was a problem hiding this comment.
Yeah, that goes for all ABI break PRs with the way we handle incrementing SYCL_DEV_ABI_VERSION right now.
|
@steffenlarsen Could you please merge this one? |
|
Looks like this introduced a post-commit failure, looking into it |
sergey-semenov
added a commit
to sergey-semenov/llvm
that referenced
this pull request
Aug 17, 2022
Revert some accidental changes from intel#6555
steffenlarsen
pushed a commit
that referenced
this pull request
Aug 18, 2022
) Revert some accidental changes from #6555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several new members were added to CG/handler via the extended member
workaround. This patch promotes them to actual fields of those classes
now that the ABI can be broken.