-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Move SPIRV test into proper directory #6589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Something bad happened during SPIRV pulldown, fix it.
These
In OCL Linux testing are unrelated. I'll try to see if they have been reported already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
intel/llvm-test-suite#1040 seems to take care of the failing test. |
@intel/llvm-gatekeepers PR is ready. |
Seems to need approval from @pvchupin as code owner. |
@dbudanov-cmplr, can you follow up on this? |
It used to fail on OpenCL CPU and GPU, but in your testing fails on CPU only. |
I am currently attempting to reproduce the failure. |
The problem was introduced by commit 36a19b6. The only reasonable explanation of what happened is that there were 2 patches one for lib/SPIRV/SPIRVUtil.cpp which was taken and applied properly. And the second for test/transcoding/SPV_INTEL_joint_matrix/sycl_2020_namespace.ll which was taken relativity to llvm-spirv but applied to llvm. |
Something bad happened during SPIRV pulldown, fix it.