Skip to content

[SYCL] Add missing sycl::span constructor #6593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

@AlexeySachkov AlexeySachkov commented Aug 17, 2022

Fixed a compilation issue with fully specialized sycl::span and extent deduction for unspecialized sycl::span created from an array.

Fixed a compilation issue with fully specialized sycl::span.
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner August 17, 2022 11:04
@AlexeySachkov
Copy link
Contributor Author

Failed llvm-test-suite test is not caused by the patch and should be fixed by intel/llvm-test-suite#1040

@AlexeySachkov
Copy link
Contributor Author

@intel/llvm-reviewers-runtime, @cperkinsintel, could you please take a look?

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit 2b50820 into intel:sycl Aug 19, 2022
@AlexeySachkov AlexeySachkov deleted the private/asachkov/add-missing-span-constructor branch May 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants