Skip to content

[SYCL][ABI-Break] Make sycl::exception has_context noexcept #6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steffenlarsen
Copy link
Contributor

According to the SYCL 2020 specification the has_context member in sycl::exception must be noexcept. This commit adds noexcept to the member function.

According to the SYCL 2020 specification the has_context member in
sycl::exception must be noexcept. This commit adds noexcept to the
member function.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner August 17, 2022 19:43
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish all incoming reviews were that simple :)

@steffenlarsen steffenlarsen merged commit ad923c9 into intel:sycl Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants