Skip to content

[SYCL] Properly apply a mask of supported queue properties in the OpenCL plugin #6622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

againull
Copy link
Contributor

"discard_events" property is passed to all backends during queue creation.
OpenCL runtime itself is not aware of such property so we need to apply
a mask of supported properties before calling OpenCL API for queue
creation. By mistake mask was applied only for OpenCL 2.0, this PR makes
it to be applied for OpenCL 1.2 as well.

…nCL plugin

"discard_events" property is passed to all backends during queue creation.
OpenCL runtime itself is not aware of such property so we need to apply
a mask of supported properties before calling OpenCL API for queue
creation. By mistake mask was applied only for OpenCL 2.0, this PR makes
it to be applied for OpenCL 1.2 as well.
@againull againull requested a review from a team as a code owner August 22, 2022 19:15
@againull againull requested a review from cperkinsintel August 22, 2022 19:15
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@againull againull merged commit c0d639e into intel:sycl Aug 22, 2022
@againull againull deleted the follow_up_fix_discard branch December 3, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants