[SYCL] Fix template argument propagation in AccessorSubscript #6669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where partial subscripts would fail to compile due to template errors. Signed-off-by: Larsen, Steffen <[email protected]>
Do we need a micro unit-test for the change as well? |
steffenlarsen
added a commit
to steffenlarsen/llvm-test-suite
that referenced
this pull request
Aug 31, 2022
Adds a regression test checking that the subscript operator on a 3-dimensional local_accessor compiles and runs as expected. This is related to intel/llvm#6669 Signed-off-by: Larsen, Steffen <[email protected]>
I have added a small reproducer test in intel/llvm-test-suite#1191. |
|
/verify with intel/llvm-test-suite#1191 |
|
@smaslov-intel - Friendly ping. |
smaslov-intel
approved these changes
Sep 2, 2022
Yes, both in CTS and in intel/llvm-test-suite#1191. |
steffenlarsen
added a commit
to intel/llvm-test-suite
that referenced
this pull request
Sep 21, 2022
Adds a regression test checking that the subscript operator on a 3-dimensional local_accessor compiles and runs as expected. This is related to intel/llvm#6669 Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…m-test-suite#1191) Adds a regression test checking that the subscript operator on a 3-dimensional local_accessor compiles and runs as expected. This is related to intel#6669 Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where partial subscripts would fail to compile due to template errors.
Found through CTS testing.