[SYCL] Decouple data types of SYCL builtins from OpenCL. #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyvoronov-intel
force-pushed
the
private/avoronov/gen_type_traits_ref
branch
from
474b396 to
cb1f51d
Compare
keryell
suggested changes
Sep 27, 2019
| return __sycl_std::__invoke_half_sqrt<T>(x); | ||
| } | ||
|
|
||
| // genfloatf tan (genfloatf x) | ||
| template <typename T> | ||
| typename std::enable_if<detail::is_genfloatf<T>::value, T>::type | ||
| tan(T x) __NOEXC { | ||
| detail::enable_if_t<detail::is_genfloatf<T>::value, T> tan(T x) __NOEXC { |
There was a problem hiding this comment.
Arrived here I have an overdose of detail::enable_if_t<detail::is_genfloatf<T>::value, T> :-)
What about defining a meta-function with using to factorize out this?
Add as many meta-function you can to reduce the code size...
There was a problem hiding this comment.
Hi, I agree with your comment, but I'd prefer not to inflate this patch any further.
In the near future I will create a couple of patches for this functionality and I will apply your suggestion in them.
Could you provide a small code snippet of what you would like this code to look like?
There was a problem hiding this comment.
We need to find a name understandable by native English speakers, which I am not...
A few ideas
detail::enable_if_genfloat_t<T> tan(T x) __NOEXC {
detail::only_genfloat_t<T> tan(T x) __NOEXC {
detail::only<detail::is_genfloatf, T> tan(T x) __NOEXC {
cb1f51d to
5f1d64b
Compare
sergey-semenov
previously approved these changes
Sep 27, 2019
Removed all use of OpenCL types from SYCL header files, aside from converting into SPIRV type. Removed some code dublications. Aligned built-in's host version with SPIRV types. Aligned nan built-in implementation with SYCL specification. Renamed detail/type_tratis.hpp to detail/std_type_tratis.hpp Updated SFINAE logic of intel/sub_group.hpp Added test for built-in's type_tratis Signed-off-by: Alexey Voronov <[email protected]>
alexeyvoronov-intel
force-pushed
the
private/avoronov/gen_type_traits_ref
branch
from
5f1d64b to
0f3c5db
Compare
bader
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexey Voronov [email protected]