Skip to content

[SYCL] Implement local_accessor begin/end #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 22, 2022
Merged

[SYCL] Implement local_accessor begin/end #6692

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f31f26e
[SYCL][ABI-BREAK] Implement accessor begin/end
KornevNikita Aug 31, 2022
2813ac1
Merge branch 'sycl' of https://github.com/intel/llvm into accessor-it…
KornevNikita Sep 2, 2022
7d6106d
Merge branch 'sycl' of https://github.com/intel/llvm into accessor-it…
KornevNikita Sep 7, 2022
9441e5c
Implement local_accessor iterator funcs
KornevNikita Sep 9, 2022
2cf0f22
Fix clang-format
KornevNikita Sep 9, 2022
faf32c0
Merge branch 'sycl' of https://github.com/intel/llvm into accessor-it…
KornevNikita Sep 9, 2022
5f4315c
Remove accessor changes
KornevNikita Sep 19, 2022
fe3ac6c
Merge branch 'sycl' of https://github.com/intel/llvm into accessor-it…
KornevNikita Sep 19, 2022
af5dd11
Typo
KornevNikita Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions sycl/include/sycl/accessor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2529,6 +2529,12 @@ class __SYCL_SPECIAL_CLASS __SYCL_TYPE(local_accessor) local_accessor
// Use base classes constructors
using local_acc::local_acc;

using value_type = DataT;
using iterator = value_type *;
using const_iterator = const value_type *;
using reverse_iterator = std::reverse_iterator<iterator>;
using const_reverse_iterator = std::reverse_iterator<const_iterator>;

#ifdef __SYCL_DEVICE_ONLY__

// __init needs to be defined within the class not through inheritance.
Expand All @@ -2550,6 +2556,24 @@ class __SYCL_SPECIAL_CLASS __SYCL_TYPE(local_accessor) local_accessor
#endif

public:
iterator begin() const noexcept {
return &this->operator[](id<Dimensions>());
}
iterator end() const noexcept { return begin() + this->size(); }

const_iterator cbegin() const noexcept { return const_iterator(begin()); }
const_iterator cend() const noexcept { return const_iterator(end()); }

reverse_iterator rbegin() const noexcept { return reverse_iterator(end()); }
reverse_iterator rend() const noexcept { return reverse_iterator(begin()); }

const_reverse_iterator crbegin() const noexcept {
return const_reverse_iterator(end());
}
const_reverse_iterator crend() const noexcept {
return const_reverse_iterator(begin());
}

template <typename Property> bool has_property() const noexcept {
#ifndef __SYCL_DEVICE_ONLY__
return this->getPropList().template has_property<Property>();
Expand Down