[CI][NFC] Fixed GFX driver update PR #6723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvchupin
reviewed
Sep 7, 2022
| ref: | ||
| description: "Commit to use for checkout or github.sha by default" | ||
| type: string | ||
| required: false |
There was a problem hiding this comment.
should we have github.sha as default here? and use just inputs.ref below?
There was a problem hiding this comment.
I'm not sure you can use variable like ${{github.sha}} as default value here. Only constants are possible I think.
There was a problem hiding this comment.
Looks like you are right and we can use variables in this place after Azure/actions#2 fix
There was a problem hiding this comment.
P.S. Also noticed I used it before in uniq input param just fine :)
pvchupin
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now generate test matrix correctly use github.event.pull_request.head.sha that is required for pull_request_target.