Skip to content

[SYCL][Doc] Closing the ABI breaking changes window #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions sycl/doc/developer/ABIPolicyGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,20 +106,6 @@ owners for help.
**Note**: Features clearly marked as experimental are considered as an exception
to this guideline.

### ABI breaking changes window June 15 - September 15 2022
### ABI breaking changes window June 15 - September 15 2022 [CLOSED]

Since the point when ABI was frozen ~2 years ago we have accumulated a significant
volume of changes, which require breaking ABI. We are opening a window to
implement these changes. During this period of time ABI breaking changes will be
accepted. All breaking changes will still require a good justification.

Whenever you need to change the existing ABI, please, follow these steps:

1. Add [ABI-break] tag to your PR title.
2. Update your PR description with rationale why breaking ABI is necessary.
3. Fix failing ABI tests in your Pull Request. Use aforementioned techniques to
update test files.
4. Increment library engineering version together with the change ("-V" postfix
part of version, as described above)

At the end of this window we will increment major version of the DPC++ library
Next ABI breaking changes window is TBD.