Skip to content

[SYCL][L0] Use compute engine for memory fill command #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

smaslov-intel
Copy link
Contributor

@smaslov-intel smaslov-intel commented Sep 16, 2022

E2E test in intel/llvm-test-suite#1273
Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel requested review from a team as code owners September 16, 2022 01:11
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM!

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible, please add a comment about why 'fill' operations needs to go to compute engine.

Thanks

@smaslov-intel
Copy link
Contributor Author

If possible, please add a comment about why 'fill' operations needs to go to compute engine.

I intentionally didn't put any explanation because I don't know a good one. Added env var will allow users to check both and use whatever works best for them.

@smaslov-intel
Copy link
Contributor Author

@steffenlarsen, @againull : can this be merged? (the pre-commit failure isn't related)

@againull againull merged commit e59098a into intel:sycl Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants