Skip to content

[SYCL][libdevice] Add __imf_llmax/min, __imf_ullmax/min, __imf_umax/min #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Sep 17, 2022

Signed-off-by: jinge90 [email protected]

Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 requested a review from v-klochkov September 19, 2022 06:49
Signed-off-by: jinge90 <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented Sep 22, 2022

Hi, @intel/dpcpp-tools-reviewers
Could you help review this PR?
Thanks very much.

@jinge90 jinge90 requested a review from pvchupin September 23, 2022 02:29
@jinge90
Copy link
Contributor Author

jinge90 commented Sep 23, 2022

Hi, @pvchupin
Could you take a look at this PR?
Thanks very much.

@asudarsa
Copy link
Contributor

Hi @jinge90

Can you please provide a 1-2 line description for this change?

Thanks

@xtian-github
Copy link

Hi @jinge90

Can you please provide a 1-2 line description for this change?

Thanks

These math functions/operations are implemented to match CUDA math functions/operations for SYCL and OpenMP offloading on GPU. Which is part of DSE OKR.

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add tests if possible. Thanks

@jinge90
Copy link
Contributor Author

jinge90 commented Sep 24, 2022

LGTM. Please add tests if possible. Thanks

Hi, @asudarsa
The test is here in review: intel/llvm-test-suite#1275

Thanks very much.

Copy link

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-klochkov v-klochkov merged commit cdc6ba8 into intel:sycl Sep 26, 2022
@jinge90 jinge90 deleted the add_max_min_for_ull_ll branch December 8, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants