-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][libdevice] Add __imf_llmax/min, __imf_ullmax/min, __imf_umax/min #6811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Hi, @intel/dpcpp-tools-reviewers |
Hi, @pvchupin |
Hi @jinge90 Can you please provide a 1-2 line description for this change? Thanks |
These math functions/operations are implemented to match CUDA math functions/operations for SYCL and OpenMP offloading on GPU. Which is part of DSE OKR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please add tests if possible. Thanks
Hi, @asudarsa Thanks very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: jinge90 [email protected]