[SYCL] Fix PI_KERNEL_MAX_SUB_GROUP_SIZE in OpenCL backend #6849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently PI_KERNEL_MAX_SUB_GROUP_SIZE in the PI OpenCL backend uses the max work item sizes as the input to the corresponding OpenCL query to avoid truncation. However, using the max work item sizes in all dimensions may exceed the total max work items limitations. To prevent this limit from being exceeded, this commit changes the query to only use the max work-item size in the first dimension and using 1s in the other dimensions. Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1266 |
Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1266 |
dm-vodopyanov
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PI_KERNEL_MAX_SUB_GROUP_SIZE in the PI OpenCL backend uses the max work item sizes as the input to the corresponding OpenCL query to avoid truncation. However, using the max work item sizes in all dimensions may exceed the total max work items limitations. To prevent this limit from being exceeded, this commit changes the query to only use the max work-item size in the first dimension and using 1s in the other dimensions.