[SYCL] Optimize operator[] method of host accessor #6853
Conversation
Compiler cannot optimize out calls to getPtr(), getOffset() and getMemoryRange(), that were used in accessor::operator[], because they may have side effects(e.g. printf). The patch adds a member in the accessor which points to the actual data stored in the accessor_impl. This pointer is initialized once during construction and used instead of functions mentioned above.
| @@ -0,0 +1,26 @@ | |||
| // RUN: %clangxx -O2 -fsycl -S -emit-llvm %s -o - | FileCheck %s | |||
There was a problem hiding this comment.
I think this test is supposed to call only a host compiler.
There was a problem hiding this comment.
Modified the compile line. Is there a convenient way to call the host compiler only?
There was a problem hiding this comment.
I think -fsycl-host-only might be helpful.
There was a problem hiding this comment.
Cannot find this option in the clang's help.
There was a problem hiding this comment.
https://github.com/intel/llvm/blob/sycl/sycl/test/lit.cfg.py#L89 - it looks like it's a front-end option.
|
@romanovvlad, post commit issues: https://github.com/intel/llvm/actions/runs/3113733433/jobs/5048727706 |
Fix for them #6875 |
Compiler cannot optimize out calls to getPtr(), getOffset() and getMemoryRange(), that were used in accessor::operator[], because they may have side effects(e.g. printf). The patch adds a member in the accessor which points to the actual data stored in the accessor_impl. This pointer is initialized once during construction and used instead of functions mentioned above.