[SYCL][Reduction] Improve getGroupsCounterAccDiscrete performance #6858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steffen Larsen <[email protected]>
v-klochkov
reviewed
Sep 23, 2022
| device Dev = q.get_device(); | ||
| auto Deleter = [=](auto *Ptr) { free(Ptr, q); }; | ||
|
|
||
| std::shared_ptr<int> Counter(malloc_device<int>(1, q), Deleter); |
There was a problem hiding this comment.
Here it is assumed that 'device' allocation is always supported.
If there are any real chance that it is not supported somewhere, then may need to have a copy of that older code.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 23, 2022
Follow-up for intel#6858 based on post-commit review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.