Skip to content

[SYCL] Fix post commit fails. #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022
Merged

[SYCL] Fix post commit fails. #6875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sycl/test/abi/sycl_symbols_windows.dump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,7 @@
?get@kernel@_V1@sycl@@QEBAPEAU_cl_kernel@@XZ
?get@platform@_V1@sycl@@QEBAPEAU_cl_platform_id@@XZ
?get@queue@_V1@sycl@@QEBAPEAU_cl_command_queue@@XZ
?getAccData@AccessorBaseHost@detail@_V1@sycl@@QEAAAEAUAccHostDataT@234@XZ
?getAccessRange@AccessorBaseHost@detail@_V1@sycl@@QEAAAEAV?$range@$02@34@XZ
?getAccessRange@AccessorBaseHost@detail@_V1@sycl@@QEBAAEBV?$range@$02@34@XZ
?getAssertHappenedBuffer@queue@_V1@sycl@@AEAAAEAV?$buffer@UAssertHappened@detail@_V1@sycl@@$00V?$aligned_allocator@UAssertHappened@detail@_V1@sycl@@@234@X@23@XZ
Expand Down
2 changes: 1 addition & 1 deletion sycl/test/basic_tests/accessor/host_acc_opt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
// CHECK: define {{.*}}foo{{.*}} {
// CHECK-NOT: call
// CHECK-NOT: invoke
// CHECK: vector.body:
// CHECK-NOT: call
// CHECK-NOT: invoke
Comment on lines 12 to 13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't needed anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the change lines 10-11 stopped working on line 12. Now line 12 doesn't exist so 10-11 are still in effect here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, will update in a separate PR. Thank you for noting.

// CHECK: load <4 x i32>
Expand All @@ -18,6 +17,7 @@
// CHECK: store <4 x i32>
// CHECK-NOT: call
// CHECK-NOT: invoke
// CHECK: }
void foo(sycl::accessor<int, 1, sycl::access::mode::read_write,
sycl::target::host_buffer> &Acc,
int *Src) {
Expand Down