[SYCL] Fix SYCL accessor.get_count() and accessor.get_size() methods. #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
previously approved these changes
Oct 7, 2019
alexeyvoronov-intel
force-pushed
the
private/avoronov/fix_accessor_getters_size_and_count
branch
from
0891169 to
2176338
Compare
|
Just rebased. |
…ods. A non-local accessor returned incorrect values when it was created with the provided range which was different from the buffer range. Signed-off-by: Alexey Voronov <[email protected]>
alexeyvoronov-intel
force-pushed
the
private/avoronov/fix_accessor_getters_size_and_count
branch
from
2176338 to
98950bb
Compare
romanovvlad
approved these changes
Nov 6, 2019
romanovvlad
changed the title
alexeyvoronov-intel
changed the title
alexeyvoronov-intel
deleted the
private/avoronov/fix_accessor_getters_size_and_count
branch
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Oct 6, 2020
* Handle @llvm.memset.* with non-constant arguments There is no SPIR-V counterpart for @llvm.memset.* intrinsic. Cases with constant value and length arguments are emulated via "storing" a constant array to the destination. For other cases we wrap the intrinsic in @spirv.llvm_memset_* function and expand the intrinsic to a loop via expandMemSetAsLoop() from llvm/Transforms/Utils/LowerMemIntrinsics.h. During reverse translation from SPIR-V to LLVM IR we can detect @spirv.llvm_memset_* and replace it with @llvm.memset. Signed-off-by: Alexey Sotkin <[email protected]> Co-authored-by: Sven van Haastregt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-local accessor returned incorrect values when it was created
with the provided range which was different from the buffer range.
Signed-off-by: Alexey Voronov [email protected]