[NFC] Fix fail on Windows #7064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elizabeth Andrews <[email protected]>
|
I believe this fixed the post-commit fail after - #7015, but I couldn't get a Windows compiler to build and so I have not tested this. |
premanandrao
approved these changes
Oct 14, 2022
It was 'unsigned long long' |
|
ESIMD issues are unrelated and expected to be fixed by #6661 |
|
@elizabethandrews, looks like one test still fails: https://github.com/intel/llvm/actions/runs/3252241458/jobs/5338227023 |
I fixed it here - #7082. I was able to test a Windows build this time and this test passes with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_t differences cause different IR in Windows and Linux.
Signed-off-by: Elizabeth Andrews [email protected]