[SYCL] Clang driver support of existing AOT features #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2019 06:46
SYCL Runtime will need to know the target information for each image so that the images can be properly dispatched between correspondent devices Signed-off-by: Sergey Semenov <[email protected]> Signed-off-by: Artem Gindinson <[email protected]>
Up until now, multiple use cases did not function properly. These can be divided into 2 groups: 1) multiple triples for different binaries not being propagated to the final offload; 2) misbehaviour of -fsycl-targets and -fsycl-add-targets options' conjunction, Driver not constructing jobs for the former. Main steps taken: 1) -fsycl-add-targets option conjunction & syntax checking was moved from SYCL's SpecializedBuilder to the Driver class to unify its handling with -fsycl-targets & -fsycl-link-targets; 2) separate toolchains are now constructed for -fsycl-add-targets' triples in order to conviniently propagate the triples to the offload jobs; 3) default toolchain construction is now switched off by -fsycl-add-targets, as is the case with other -fsycl*targets options; 4) clear differentiation between -fsycl-add-targets' AOT inputs and other option's inputs (including AOT) at the SpecializedBuilder level was added to create necessary jobs both for -fsycl-targets and -fsycl-add-targets. Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
requested review from
kbobrovs,
romanovvlad,
smaslov-intel,
sndmitriev,
asavonic and
sergey-semenov
AGindinson
commented
Oct 9, 2019
AGindinson
commented
Oct 9, 2019
added 2 commits
October 9, 2019 21:22
Code duplication and deep nesting are thus reduced Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
hchilama
approved these changes
Oct 9, 2019
hchilama
previously approved these changes
Oct 9, 2019
agozillon
reviewed
Oct 9, 2019
AGindinson
force-pushed
the
private/agindins/fsycl-add-targets
branch
from
4a81c44 to
67ce950
Compare
|
@agozillon Thanks for the review! |
vladimirlaz
approved these changes
Oct 10, 2019
vladimirlaz
added a commit
that referenced
this pull request
Feb 18, 2020
Resolve merge conflict in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commit messages for detailed descriptions.