Skip to content

[CI][1/3] Add Ubuntu 22 containers build #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 10, 2022
Merged

Conversation

pvchupin
Copy link
Contributor

@pvchupin pvchupin commented Oct 18, 2022

It mostly copy-paste from Ubuntu 20 containers with one additional fix needed for ROCm.
I couldn't make containers push work from PR pull_request workflow.
Hope that it will work via scheduled workflow trigger.

Also ignore sycl_containers workflow change in pre-commit. New containers when tested in PRs are not getting pushed so actual testing doesn't make sense.

@pvchupin pvchupin requested a review from a team as a code owner October 18, 2022 21:04
@pvchupin
Copy link
Contributor Author

pvchupin commented Oct 19, 2022

Looks like ROCm is not ready for Ubuntu 22, same issue as at the bottom of: ROCm/ROCm#1713

@keryell
Copy link
Contributor

keryell commented Oct 19, 2022

Looks like ROCm is not ready for Ubuntu 22, same issue as at the bottom of: RadeonOpenCompute/ROCm#1713

@saadrahim I think it is supported according to https://docs.amd.com/bundle/ROCm-Release-Notes-v5.3/page/About_This_Document.html
That said I have not tried myself yet. I should have more physical time in from of my Ubuntu 22.04 server next week to try.

Pavel V Chupin added 4 commits October 27, 2022 14:22
This is needed to have initial set of Ubuntu 22 containers
For some reason containers failed to push to the project. My guess is
that GITHUB_TOKEN doesn't work as expected for pull_request.
May need to merge this to test further.
@pvchupin pvchupin changed the title [CI] Uplift containers to Ubuntu 22 [CI] Add Ubuntu 22 containers build Nov 4, 2022
@pvchupin
Copy link
Contributor Author

pvchupin commented Nov 7, 2022

@intel/dpcpp-devops-reviewers this is ready to land, please review

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update documentation in sycl/doc/developer/DockerBKMs.md.

Do we still need testing with 20.04 version, or we can remove it?

@@ -0,0 +1,14 @@
ARG base_tag=latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update nightly job to produce this image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to separate that next step from this PR.

First I need to make sure base/build/intel_drivers containers can be built and pushed successfully on schedule. I have a problem pushing these from pull_request task. These are basic containers that are used everywhere.

Then I can update nightly to actually use these containers and run testing on them, we'll need to see results and if they all look good. Nightly containers push depends on successful testing results.
Let me actually cut *_preinstalled.Dockerfile from this PR, as it will be needed on the next mentioned step, not on the first one.

@pvchupin
Copy link
Contributor Author

pvchupin commented Nov 8, 2022

Please, update documentation in sycl/doc/developer/DockerBKMs.md.

Do we still need testing with 20.04 version, or we can remove it?

I'd like to split this transition on phases:

  1. Start building 22.04 basic containers in addition to 20.04 ones
  2. Start running nightly on 22.04 containers in addition to 20.04 ones and push nightly containers
  3. Finalize transition by updating documentation and removing 20.04 containers from all scripts

This PR is for 1) only. I'd like to postpone documentation update until 3)

@pvchupin pvchupin requested a review from bader November 9, 2022 00:23
@bader bader changed the title [CI] Add Ubuntu 22 containers build [CI][1/3] Add Ubuntu 22 containers build Nov 9, 2022
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I added a tag to mark that this is the first of 3 patches.

@pvchupin pvchupin merged commit 082cde6 into intel:sycl Nov 10, 2022
@pvchupin pvchupin deleted the ubuntu22 branch November 10, 2022 01:18
pvchupin pushed a commit to pvchupin/llvm that referenced this pull request Nov 10, 2022
Follow up on intel#7106, this is patch 2 of 3 patches expected:

Start running nightly on 22.04 containers in addition to 20.04 ones and push
nightly containers.
This is basically a copy-paste from 20.04 parts.

As before push is not expected to happen until this change is actually
merged. Based on the previous patch testing it seems it works well after
merge and doesn't really work in pull_request mode.

Adding more workflows to ignore in sycl_precommit.
pvchupin pushed a commit that referenced this pull request Nov 14, 2022
Follow up on #7106, this is patch 2 of 3 patches expected:

Start running nightly on 22.04 containers in addition to 20.04 ones and
push nightly containers.
This is basically a copy-paste from 20.04 parts.

As before push is not expected to happen until this change is actually
merged. Based on the previous patch testing it seems it works well after
merge and doesn't really work in pull_request mode.

Adding more workflows to ignore in sycl_precommit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants