-
Notifications
You must be signed in to change notification settings - Fork 787
[CI][1/3] Add Ubuntu 22 containers build #7106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like ROCm is not ready for Ubuntu 22, same issue as at the bottom of: ROCm/ROCm#1713 |
@saadrahim I think it is supported according to https://docs.amd.com/bundle/ROCm-Release-Notes-v5.3/page/About_This_Document.html |
This is needed to have initial set of Ubuntu 22 containers
For some reason containers failed to push to the project. My guess is that GITHUB_TOKEN doesn't work as expected for pull_request. May need to merge this to test further.
@intel/dpcpp-devops-reviewers this is ready to land, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update documentation in sycl/doc/developer/DockerBKMs.md.
Do we still need testing with 20.04 version, or we can remove it?
@@ -0,0 +1,14 @@ | |||
ARG base_tag=latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update nightly job to produce this image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to separate that next step from this PR.
First I need to make sure base/build/intel_drivers containers can be built and pushed successfully on schedule. I have a problem pushing these from pull_request task. These are basic containers that are used everywhere.
Then I can update nightly to actually use these containers and run testing on them, we'll need to see results and if they all look good. Nightly containers push depends on successful testing results.
Let me actually cut *_preinstalled.Dockerfile from this PR, as it will be needed on the next mentioned step, not on the first one.
I'd like to split this transition on phases:
This PR is for 1) only. I'd like to postpone documentation update until 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I added a tag to mark that this is the first of 3 patches.
Follow up on intel#7106, this is patch 2 of 3 patches expected: Start running nightly on 22.04 containers in addition to 20.04 ones and push nightly containers. This is basically a copy-paste from 20.04 parts. As before push is not expected to happen until this change is actually merged. Based on the previous patch testing it seems it works well after merge and doesn't really work in pull_request mode. Adding more workflows to ignore in sycl_precommit.
Follow up on #7106, this is patch 2 of 3 patches expected: Start running nightly on 22.04 containers in addition to 20.04 ones and push nightly containers. This is basically a copy-paste from 20.04 parts. As before push is not expected to happen until this change is actually merged. Based on the previous patch testing it seems it works well after merge and doesn't really work in pull_request mode. Adding more workflows to ignore in sycl_precommit.
It mostly copy-paste from Ubuntu 20 containers with one additional fix needed for ROCm.
I couldn't make containers push work from PR pull_request workflow.
Hope that it will work via scheduled workflow trigger.
Also ignore sycl_containers workflow change in pre-commit. New containers when tested in PRs are not getting pushed so actual testing doesn't make sense.