[SYCL] Use image pointer as a unique identifier for cache #7113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently different paths for building programs use different cache keys. Specifically, one path uses the kernel-set-id while another uses the pointer to the binary image. This may cause device binaries built by both paths may cause the programs to be rebuilt. Additionally, since the kernel-set-id may cover multiple device binaries, it may make colliding cache kernels. To fix the problems this commit will change the key use an image identifier rather than the kernel-set-id. We use the device binary pointer as the unique identifier. Signed-off-by: Larsen, Steffen <[email protected]>
romanovvlad
approved these changes
Oct 19, 2022
steffenlarsen
added a commit
that referenced
this pull request
Oct 21, 2022
)" This reverts commit a0254c9.
This was referenced Oct 21, 2022
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Oct 31, 2022
MultipleDevsCache has been failing testing in post-commit on Windows sporadically since intel#7113. This commit disables the test on Windows while the cause of the sporadic behavior is investigated and fixed. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently different paths for building programs use different cache keys. Specifically, one path uses the kernel-set-id while another uses the pointer to the binary image. This may cause device binaries built by both paths may cause the programs to be rebuilt. Additionally, since the kernel-set-id may cover multiple device binaries, it may make colliding cache kernels.
To fix the problems this commit will change the key use an image identifier rather than the kernel-set-id. We use the device binary pointer as the unique identifier.