[SYCL] Specify output file for ocl-icd external project. #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asavonic
reviewed
Oct 9, 2019
sycl/CMakeLists.txt
Outdated
| @@ -104,6 +104,7 @@ if( NOT OpenCL_LIBRARIES ) | |||
| ${OPENCL_ICD_LOADER_WDK} | |||
| STEP_TARGETS configure,build,install | |||
| DEPENDS ocl-headers | |||
| BUILD_BYPRODUCTS ${LLVM_BINARY_DIR}/lib/libOpenCL.so | |||
There was a problem hiding this comment.
You won't have libOpenCL.so as a build product on Windows. Shouldn't it be OpenCL.lib or OpenCL.dll?
It's needed for ninja to correctly process dependencies. Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
force-pushed
the
private/vromanov/ICDOutput
branch
from
a03a106 to
52faf41
Compare
asavonic
approved these changes
Oct 10, 2019
vladimirlaz
pushed a commit
that referenced
this pull request
Sep 29, 2020
This is achieved by guarding most (only covered LLVM IR -> SPIR-V passes) `verifyModule` calls by corresponding command line option, which is disabled/enabled in accordance with _SPIRVDBG define. Made _SPIRVDBG define disabled in release builds by default. Adjusted SPIRVErrorLog::CheckError to not use `spvdbg` for printing information about errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed for ninja to correctly process dependencies.
Signed-off-by: Vlad Romanov [email protected]