Skip to content

Revert "[SYCL] Use copy engine for memory read/write operations" #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

Revert "[SYCL] Use copy engine for memory read/write operations" #7124

merged 1 commit into from
Oct 20, 2022

Conversation

smaslov-intel
Copy link
Contributor

Reverts #6783

@smaslov-intel smaslov-intel requested a review from a team as a code owner October 19, 2022 21:29
asudarsa
asudarsa approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@asudarsa
Copy link
Contributor

Hi @smaslov-intel
I am trying out a quick fix. Can you please hold off a bit before submission. Thanks

@smaslov-intel
Copy link
Contributor Author

Hi @smaslov-intel I am trying out a quick fix. Can you please hold off a bit before submission. Thanks

@againull : we agreed with @asudarsa that this needs to be merged now. could you please merge this?

@againull againull merged commit 44aa363 into sycl Oct 20, 2022
@pvchupin pvchupin deleted the revert-6783-asudarsa/use_copy_engine_for_memread_memwrite branch October 20, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@againull againull againull approved these changes

@asudarsa asudarsa asudarsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smaslov-intel @asudarsa @againull