[NFC][SYCL] Minor refactor around KernelPropertiesUnpacker #7125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
force-pushed
the
unpack-refactor
branch
2 times, most recently
from
f152969 to
d1995b1
Compare
aelovikov-intel
force-pushed
the
unpack-refactor
branch
from
d1995b1 to
6d17c8f
Compare
aelovikov-intel
changed the title
steffenlarsen
approved these changes
Oct 20, 2022
sycl/include/sycl/handler.hpp
Outdated
|
|
||
| // Wrappers for kernel_*** functions above with and without support of | ||
| // additional kernel_handler argument. | ||
| // Wrappers for kernel_*** functions above supporting scenarios with and |
There was a problem hiding this comment.
I feel like "above" is a little vague now that it's not in the same class. Maybe it makes more sense to mention that they're in KernelPropertiesUnpackerImpl instead?
steffenlarsen
approved these changes
Oct 20, 2022
|
CUDA failure: Failed Tests (1): is unrelated, addressed in intel/llvm-test-suite#1338 IIUC. @intel/llvm-gatekeepers , OK to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.