[SYCL] Wait for stream service tasks #7130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch adds more logic to default redefinitions of PI APIs: 1. Allocate, refcount and deallocated various handles 2. Handle sub-buffer creation Also the patch adds support for adding PI functions to be called in addition (before or after) to the original function. This allows intersecting PI API calls for introspection while still allowing original function take care of handles. Or add some post processing of the returned values.
Before the patch explicit waiting for the task which is expected to print a message using sycl::stream doesn't guarantee that the message is actually printed(the printing may happen later). The patch adds such a guarantee by regestering events of stream service tasks in the user event produced for the original user task as well as in the queue where this task is submitted to. Then on explicit calls to queue::wait and event::wait we make sure that these additional events are complete as well.
romanovvlad
changed the title
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Nov 4, 2022
intel#7130 added new ABI symbols but forgot to add the new symbol to the Windows ABI test. This commit adds the missing symbol. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
added a commit
that referenced
this pull request
Nov 4, 2022
#7130 added new ABI symbols but forgot to add the new symbol to the Windows ABI test. This commit adds the missing symbol. Signed-off-by: Larsen, Steffen <[email protected]>
|
@romanovvlad, new post-commit fail: https://github.com/intel/llvm/actions/runs/3390067093/jobs/5633796277 |
Fixing. #7287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the patch explicit waiting for the task which is expected to
print a message using sycl::stream doesn't guarantee that the message is
actually printed(the printing may happen later).
The patch adds such a guarantee by registering events of stream service
tasks in the user event produced for the original user task as well as
in the queue where this task is submitted to. Then on explicit calls to
queue::wait and event::wait we make sure that these additional events
are complete as well.