[SYCL][NFC] Add additional test case to emit_program_metadata #7135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an additional test case to emit_program_metadata for checking that the "sycl-work-group-size" gets correctly represented in program metadata. Signed-off-by: Larsen, Steffen <[email protected]>
|
Is there a recent commit that this test intends to cover? Thanks |
Yes, this is related to #7017. The program metadata is only used by the CUDA backend right now, so the test wasn't though of at the time. However, CUDA is currently failing one of the tests added with the runtime changes (intel/llvm-test-suite#1338) so these changes were made to make sure it wasn't caused by sycl-post-link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an additional test case to emit_program_metadata for checking that the "sycl-work-group-size" gets correctly represented in program metadata.