[SYCL] Select a more consistent image ID for caching #7154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The program cache was recently changed to use the device image pointer as part of its cache key. However, pointers are unreliable as assigning device images may mean that device images may change identifiers. This commit changes the selected identifier to be a counter instead of using the pointer value. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
|
As per offline discussion with @romanovvlad I have changed the identifier to be the pointer to the |
romanovvlad
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program cache was recently changed to use the device image pointer as part of its cache key. However, the
RTDeviceBinaryImageclass has move constructor and assignment operator defined to allow them to transition between collections, so the pointers can change, making them an unreliable cache key. This commit changes the selected identifier to be the pointer to the underlying binary image instead.