Skip to content

[SYCL] Fix accessor::swap() method #7201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Oct 27, 2022

Need to swap new member MAccData (added in 01e60f7) in addition to Impl.

@KornevNikita KornevNikita requested a review from a team as a code owner October 27, 2022 13:25
Need to swap new member MAccData in addition to Impl
01e60f7
@KornevNikita KornevNikita requested review from a team and romanovvlad October 27, 2022 13:25
@KornevNikita
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1265

@KornevNikita
Copy link
Contributor Author

I believe this failure is unrelated, but I don't see any failures in another PRs

@KornevNikita
Copy link
Contributor Author

Hello @aelovikov-intel, could you take a look please?

Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought two other approvals is enough...

I wonder why MAccData couldn't live in the impl though.

@pvchupin pvchupin merged commit d3e5273 into intel:sycl Oct 28, 2022
@KornevNikita KornevNikita deleted the fix-swap branch December 9, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants