[SYCL-MLIR][NFC] Use clang::Builtin enum when possible
#7257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
changed the title
clang::Builtin enum when possibleclang::Builtin enum when possible
etiotto
reviewed
Nov 2, 2022
Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
force-pushed
the
builtin
branch
from
95d5bd1 to
7752140
Compare
whitneywhtsang
commented
Nov 2, 2022
etiotto
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang::Builtinenum instead of string comparison when possibleEmitBuiltinOps()EmitBuiltinOps()Signed-off-by: Tsang, Whitney [email protected]