Skip to content

[SYCL-MLIR] Add back the reverted sycl commit #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

whitneywhtsang
Copy link
Contributor

@whitneywhtsang whitneywhtsang commented Nov 3, 2022

Note: Do not squash and merge.

@whitneywhtsang whitneywhtsang added the sycl-mlir Pull requests or issues for sycl-mlir branch label Nov 3, 2022
@whitneywhtsang whitneywhtsang self-assigned this Nov 3, 2022
@whitneywhtsang whitneywhtsang marked this pull request as ready for review November 3, 2022 00:53
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do I understand correctly that the runtime error was caused by a function not being emitted because it was not in the list of supported functions yet?

@whitneywhtsang whitneywhtsang merged commit 8aa68cc into intel:sycl-mlir Nov 3, 2022
@whitneywhtsang whitneywhtsang deleted the revert branch November 3, 2022 13:29
@whitneywhtsang
Copy link
Contributor Author

Do I understand correctly that the runtime error was caused by a function not being emitted because it was not in the list of supported functions yet?

That's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants