[SYCL] Make kernel-and-program unittests use unique kernels #7279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests in kernel-and-program unittests would use kernels with the same names as other tests, which could potentially cause multiple binaries with similar kernels to be found. Since the tests need consistency in their kernel_bundles this commit changes them to use unique kernels. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
romanovvlad
approved these changes
Nov 4, 2022
Signed-off-by: Larsen, Steffen <[email protected]>
|
Unrelated failure in SYCL :: Assert/assert_in_multiple_tus.cpp on CUDA. Tagging @AerialMantis for awareness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in kernel-and-program unittests would use kernels with the same names as other tests, which could potentially cause multiple binaries with similar kernels to be found. Since the tests need consistency in their kernel_bundles this commit changes them to use unique kernels.