-
Notifications
You must be signed in to change notification settings - Fork 787
[CI] enable post-commit as a workflow action. #7289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to trigger post-commit checks, especially when we aren't able to test locally. This PR makes post-commit as a dispatchable workflow. Liberte, Egalite, Fraternitegit add --update
Will it allow to run post commit jobs on a particular pull request? |
Could you please also revert 5f649e2 as a part of this pull request, since you are touching sycl_post_commit.yml? |
@Fznamznon - yes it will allow post-commit to be run on an individual PR. Once this is merged, go to Actions and find post-commit.yml in the list on the left then click the button on the right to run it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should do the trick :)
Co-authored-by: Pavel Chupin <[email protected]>
We don't need to wait for actual result. |
@Fznamznon - the solution isn't perfect yet. Now that this is merged you can run the post-commit action on any branch. Of course, the branch for your PR is likely on your own fork, which doesn't have the CI resources available. In this case, push your branch to intel/llvm for the purposes of running the post-commit action on it, and then delete the branch after. |
I don't think pushing private branch to intel/llvm repo is a good thing. I believe we need a solution that doesn't require it. |
It'd be nice to be able to trigger post-commit checks, especially when we aren't able to test locally. This PR makes post-commit as a dispatchable workflow. Liberte, Egalite, Fraternite