Skip to content

[CI] enable post-commit as a workflow action. #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

cperkinsintel
Copy link
Contributor

@cperkinsintel cperkinsintel commented Nov 4, 2022

It'd be nice to be able to trigger post-commit checks, especially when we aren't able to test locally. This PR makes post-commit as a dispatchable workflow. Liberte, Egalite, Fraternite

… to trigger post-commit checks, especially when we aren't able to test locally. This PR makes post-commit as a dispatchable workflow. Liberte, Egalite, Fraternitegit add --update
@cperkinsintel cperkinsintel requested a review from a team as a code owner November 4, 2022 18:37
@cperkinsintel cperkinsintel changed the title [CI] enable post-commit as a workflow action. It'd be nice to be able… [CI] enable post-commit as a workflow action. Nov 4, 2022
@Fznamznon
Copy link
Contributor

Will it allow to run post commit jobs on a particular pull request?

@Fznamznon
Copy link
Contributor

Fznamznon commented Nov 4, 2022

Could you please also revert 5f649e2 as a part of this pull request, since you are touching sycl_post_commit.yml?
Eating machine time to revert dummy change doesn't seem reasonable to me.

@cperkinsintel
Copy link
Contributor Author

cperkinsintel commented Nov 4, 2022

@Fznamznon - yes it will allow post-commit to be run on an individual PR. Once this is merged, go to Actions and find post-commit.yml in the list on the left then click the button on the right to run it.

I don't see an extra line sycl_post_commit.yml at line 17. Was that commit merged? My mistake - was looking at the wrong PR.

Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do the trick :)

@pvchupin
Copy link
Contributor

pvchupin commented Nov 4, 2022

We don't need to wait for actual result.

@pvchupin pvchupin merged commit 5bb9ef4 into intel:sycl Nov 4, 2022
@cperkinsintel
Copy link
Contributor Author

@Fznamznon - the solution isn't perfect yet. Now that this is merged you can run the post-commit action on any branch. Of course, the branch for your PR is likely on your own fork, which doesn't have the CI resources available. In this case, push your branch to intel/llvm for the purposes of running the post-commit action on it, and then delete the branch after.

@Fznamznon
Copy link
Contributor

@Fznamznon - the solution isn't perfect yet. Now that this is merged you can run the post-commit action on any branch. Of course, the branch for your PR is likely on your own fork, which doesn't have the CI resources available. In this case, push your branch to intel/llvm for the purposes of running the post-commit action on it, and then delete the branch after.

I don't think pushing private branch to intel/llvm repo is a good thing. I believe we need a solution that doesn't require it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants