[SYCL] Small adjustments of UpdateHostRequirementCommand. #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
KarachunIvan
previously approved these changes
Oct 14, 2019
sergey-semenov
previously approved these changes
Oct 14, 2019
|
Is there a way to regression-test this? |
Changed where UpdateHostRequirementCommand is put in, previously it was always added to write leafs, now it is added to read or write leafs depending on the type of host accessor. + Fixed UpdateHostRequirementCommand::printDot, now it prints access mode of dependency rather than alloca command. Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
dismissed stale reviews from sergey-semenov and KarachunIvan
via
d97c322
romanovvlad
force-pushed
the
private/vromanov/UpdateHostReqAdj
branch
from
6ff21fa to
d97c322
Compare
I don't think so. |
AGindinson
approved these changes
Oct 15, 2019
KarachunIvan
approved these changes
Oct 15, 2019
sergey-semenov
approved these changes
Oct 15, 2019
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
Previous fix removes substitution causing failure below: clang++: error: no such file or directory: '%fPIC'; did you mean '-fPIC'? The current fix provides substitution with empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed dependency type for UpdateHostRequirementCommand, previously it
was always read_write, now the type depends on the type user requests
when creates host accessor.
Signed-off-by: Vlad Romanov [email protected]