[SYCL][NFC] Fix bug with dereference null return value #7294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by static analyzer tool:
Dereference null return value
If the function actually returns a null value, a null pointer dereference will occur.
In <unnamed>::SyclKernelPointerHandler::leaveArray(clang::FieldDecl *, clang::QualType, clang::QualType): Return value of function which returns null is dereferenced without checking
bool leaveArray(FieldDecl *FD, QualType ArrayTy, QualType ET) final {
QualType ModifiedArrayElement = ModifiedArrayElementsOrArray.pop_back_val();
// returned_null: getAsConstantArrayType returns nullptr (checked 73 out of 88 times).
// var_assigned: Assigning: CAT = nullptr return value from getAsConstantArrayType.
const ConstantArrayType *CAT =
SemaRef.getASTContext().getAsConstantArrayType(ArrayTy);
// Dereference null return value (NULL_RETURNS)
// dereference: Dereferencing a pointer that might be nullptr CAT when calling getSizeExpr.
QualType ModifiedArray = SemaRef.getASTContext().getConstantArrayType(
ModifiedArrayElement, CAT->getSize(),
const_cast<Expr *>(CAT->getSizeExpr()), CAT->getSizeModifier(),
CAT->getIndexTypeCVRQualifiers());
This patch updates the codes to resolve the bug.
Signed-off-by: Soumi Manna <[email protected]>
elizabethandrews
approved these changes
Nov 7, 2022
premanandrao
approved these changes
Nov 7, 2022
|
Thank you everyone for reviews! |
|
@intel/llvm-gatekeepers, This PR is ready to be merged. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by static analyzer tool:
Dereference null return value
If the function actually returns a null value, a null pointer dereference will occur.
In ::SyclKernelPointerHandler::leaveArray(clang::FieldDecl *, clang::QualType, clang::QualType): Return value of function which returns null is dereferenced without checking
bool leaveArray(FieldDecl *FD, QualType ArrayTy, QualType ET) final {
QualType ModifiedArrayElement = ModifiedArrayElementsOrArray.pop_back_val();
This patch adds assert to resolve the bug.
Signed-off-by: Soumi Manna [email protected]