Skip to content

[NFCI][SYCL] Refactor reductions implementations #7322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 1 addition & 34 deletions sycl/include/sycl/handler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include <sycl/nd_item.hpp>
#include <sycl/nd_range.hpp>
#include <sycl/property_list.hpp>
#include <sycl/reduction_forward.hpp>
#include <sycl/sampler.hpp>
#include <sycl/stl.hpp>

Expand Down Expand Up @@ -268,43 +269,9 @@ class RoundedRangeKernelWithKH {
KernelType KernelFunc;
};

template <typename T, class BinaryOperation, int Dims, size_t Extent,
typename RedOutVar>
class reduction_impl_algo;

using sycl::detail::enable_if_t;
using sycl::detail::queue_impl;

// Reductions implementation need access to private members of handler. Those
// are limited to those below.
namespace reduction {
inline void finalizeHandler(handler &CGH);
template <class FunctorTy> void withAuxHandler(handler &CGH, FunctorTy Func);
} // namespace reduction

template <typename KernelName, int Dims, typename PropertiesT,
typename KernelType, typename Reduction>
void reduction_parallel_for(handler &CGH,
std::shared_ptr<detail::queue_impl> Queue,
range<Dims> Range, PropertiesT Properties,
Reduction Redu, KernelType KernelFunc);

template <typename KernelName, int Dims, typename PropertiesT,
typename KernelType, typename Reduction>
void reduction_parallel_for(handler &CGH,
std::shared_ptr<detail::queue_impl> Queue,
nd_range<Dims> Range, PropertiesT Properties,
Reduction Redu, KernelType KernelFunc);

template <typename KernelName, int Dims, typename PropertiesT,
typename... RestT>
void reduction_parallel_for(handler &CGH,
std::shared_ptr<detail::queue_impl> Queue,
nd_range<Dims> Range, PropertiesT Properties,
RestT... Rest);

template <typename T> struct IsReduction;
template <typename FirstT, typename... RestT> struct AreAllButLastReductions;
} // namespace detail

/// Command group handler class.
Expand Down
Loading