Skip to content

[SYCL] Add support for blocking enqueue #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romanovvlad
Copy link
Contributor

The patch introduces new property of the Command class: blocked from
enqueueing. This means that the command cannot be enqueued so until
it's unblocked. Places where enqueue process is initiated were updated
so all "wait for event" calls make blocking enqueue which doesn't return
until all required commands are actually enqueued.

Signed-off-by: Vlad Romanov [email protected]

Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments

The patch introduces new property of the Command class: blocked from
enqueueing. This means that the command cannot be enqueued so until
it's unblocked. Places where enqueue process is initiated were updated
so all "wait for event" calls make blocking enqueue which doesn't return
until all required commands are actually enqueued.

Signed-off-by: Vlad Romanov <[email protected]>
@romanovvlad romanovvlad force-pushed the private/vromanov/SupportForBlockingEnqueue branch from d55b76b to c74c4be Compare October 16, 2019 14:24
@romanovvlad romanovvlad merged commit 81f5dff into intel:sycl Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants