[SYCL] Optimize SYCL framework functions with -O0 #7376

maksimsab · 2022-11-11T14:41:55Z

No description provided.

… sycl namespace.

…ver. Add a warning for misuse of this option.

LLVM infrastructure does not provide a way to add a Pass Adaptor to run Function Passes on a subset of functions in a Module. This commit adds ModuleToSYCLFrameworkFunctionPassAdaptor which runs passes over functions marked by "sycl-framework" metadata.

…pipeline

maksimsab · 2022-12-08T13:39:58Z

@elizabethandrews Could you please take a look at FE part?

llvm/include/llvm/SYCLLowerIR/IR/PassAdaptors.h

clang/include/clang/Driver/Options.td

clang/lib/CodeGen/CodeGenFunction.cpp

clang/lib/Driver/ToolChains/Clang.cpp

clang/test/Driver/sycl-optimize-framework.cpp

clang/include/clang/Basic/CodeGenOptions.def

clang/test/CodeGenSYCL/sycl-framework-metadata.cpp

clang/include/clang/Driver/Options.td

clang/test/CodeGenSYCL/sycl-framework-metadata.cpp

clang/test/CodeGenSYCL/sycl-framework-metadata1.cpp

premanandrao · 2022-12-09T15:41:39Z

clang/test/CodeGenSYCL/sycl-framework-metadata2.cpp

+// Check that kernel is not marked with !sycl-framework metadata
+// CHECK-NOT: @_ZTSZ4mainE6kernel() {{.*}} !sycl-framework
+template <typename name, typename Func>
+__attribute__((sycl_kernel)) void kernel_single_task(const Func &func) {


Suggest using the interface from the mock header here too.

It leads to error because of ambiguity of sycl namespace and anonymous namespace.

clang/test/CodeGenSYCL/sycl-framework-metadata2.cpp

clang/test/Driver/sycl-optimize-framework.cpp

clang/include/clang/Basic/DiagnosticDriverKinds.td

clang/include/clang/Driver/Options.td

llvm/lib/Passes/PassBuilderPipelines.cpp

llvm/include/llvm/SYCLLowerIR/SYCLFrameworkOptimization.h

sarnex

LGTM but might want to get final review from @AlexeySachkov

clang/lib/CodeGen/CodeGenModule.cpp

clang/test/CodeGenSYCL/sycl-optimize-non-user-code-func-attrs1.cpp

clang/test/Driver/sycl-optimize-framework.cpp

llvm/lib/Passes/PassBuilderPipelines.cpp

llvm/include/llvm/SYCLLowerIR/SYCLFrameworkOptimization.h

llvm/lib/SYCLLowerIR/SYCLFrameworkOptimization.cpp

maksimsab · 2023-02-08T12:31:02Z

Hi @AlexeySachkov !
Do you have any additional thoughts on this one?

AlexeySachkov

LGTM

bader · 2023-02-09T19:59:38Z

PR title fix suggestion:

[SYCL] Optimize SYCL framework functions with -O0

asudarsa

LGTM. Thanks

maksimsab · 2023-02-14T10:59:21Z

@intel/llvm-gatekeepers Can you please merge it?

maksimsab added 2 commits December 8, 2022 05:05

[SYCL] Emit "sycl-framework" metadata attached to funcions/methods in…

acd84e0

… sycl namespace.

[SYCL] Add -fsycl-optimize-framework command line option in Clang Dri…

0e222f5

…ver. Add a warning for misuse of this option.

maksimsab force-pushed the add_new_debug_mode branch 2 times, most recently from 28b4e66 to 66642c6 Compare December 8, 2022 13:17

maksimsab force-pushed the add_new_debug_mode branch 2 times, most recently from 1b20349 to 30156c5 Compare December 8, 2022 13:33

[SYCL] Add a SYCL framework optimization pipeline to LLVM O0 default …

41bbeb7

…pipeline

maksimsab force-pushed the add_new_debug_mode branch from 30156c5 to 41bbeb7 Compare December 8, 2022 13:36

maksimsab changed the title ~~[NFC][SYCL] add optimization of SYCL framework functions in sycl-post-link~~ [SYCL] add optimization of SYCL framework functions in sycl-post-link Dec 8, 2022

maksimsab marked this pull request as ready for review December 8, 2022 13:37

maksimsab requested review from a team as code owners December 8, 2022 13:37

maksimsab requested a review from elizabethandrews December 8, 2022 13:39

maksimsab changed the title ~~[SYCL] add optimization of SYCL framework functions in sycl-post-link~~ [SYCL] add optimization of SYCL framework functions in Clang and -O0 LLVM Default Pipeline Dec 8, 2022

maksimsab commented Dec 8, 2022

View reviewed changes

llvm/include/llvm/SYCLLowerIR/IR/PassAdaptors.h Outdated Show resolved Hide resolved

AlexeySachkov reviewed Dec 8, 2022

View reviewed changes

premanandrao reviewed Dec 8, 2022

View reviewed changes

clang/include/clang/Basic/CodeGenOptions.def Outdated Show resolved Hide resolved

clang/test/CodeGenSYCL/sycl-framework-metadata.cpp Outdated Show resolved Hide resolved

elizabethandrews reviewed Dec 8, 2022

View reviewed changes

clang/include/clang/Driver/Options.td Outdated Show resolved Hide resolved

clang/test/CodeGenSYCL/sycl-framework-metadata.cpp Outdated Show resolved Hide resolved

[SYCL] fix code review remarks

8b66cf2

premanandrao reviewed Dec 9, 2022

View reviewed changes

elizabethandrews reviewed Dec 9, 2022

View reviewed changes

clang/test/CodeGenSYCL/sycl-framework-metadata2.cpp Outdated Show resolved Hide resolved

maksimsab added 2 commits December 19, 2022 06:03

[SYCL] Use sycl::kernel_single_task mock in sycl-framework-metadata1.cpp

ad2f3cd

Merge branch 'sycl' into add_new_debug_mode

6bc843a

mdtoguchi reviewed Dec 19, 2022

View reviewed changes

clang/test/Driver/sycl-optimize-framework.cpp Outdated Show resolved Hide resolved

mdtoguchi reviewed Dec 19, 2022

View reviewed changes

clang/include/clang/Basic/DiagnosticDriverKinds.td Outdated Show resolved Hide resolved

[SYCL] Fix RemoveFuncAttrsFromSYCLFrameworkFuncs pass

060da0e

maksimsab temporarily deployed to aws January 27, 2023 16:07 — with GitHub Actions Inactive

maksimsab temporarily deployed to aws January 27, 2023 16:39 — with GitHub Actions Inactive

sarnex reviewed Jan 27, 2023

View reviewed changes

[SYCL] add comment and fix a typo

1670049

maksimsab temporarily deployed to aws January 30, 2023 14:09 — with GitHub Actions Inactive

sarnex approved these changes Jan 30, 2023

View reviewed changes

smanna12 approved these changes Jan 30, 2023

View reviewed changes

AlexeySachkov reviewed Jan 30, 2023

View reviewed changes

maksimsab added 5 commits February 1, 2023 08:18

[SYCL] return noinline,optnone attrs back more accurately

77eba39

[SYCL] adjust test to error message

ba2fe26

[SYCL] use regex for matching function attributes in tests

cc077eb

[SYCL] remove AddDebugFuncsAttrs pass

524966b

[SYCL] remove useless assertion

7b4391f

maksimsab temporarily deployed to aws February 6, 2023 14:34 — with GitHub Actions Inactive

maksimsab temporarily deployed to aws February 6, 2023 15:06 — with GitHub Actions Inactive

maksimsab requested review from asudarsa and AlexeySachkov February 7, 2023 12:43

[SYCL] correct test description

91f6d96

maksimsab temporarily deployed to aws February 8, 2023 13:56 — with GitHub Actions Inactive

maksimsab temporarily deployed to aws February 9, 2023 04:52 — with GitHub Actions Inactive

AlexeySachkov approved these changes Feb 9, 2023

View reviewed changes

maksimsab changed the title ~~[SYCL] add optimization of SYCL framework functions in Clang and -O0 LLVM Default Pipeline~~ [SYCL] Add optimization of SYCL framework functions in Clang and -O0 LLVM Default Pipeline Feb 10, 2023

asudarsa approved these changes Feb 13, 2023

View reviewed changes

maksimsab requested a review from a team February 13, 2023 15:41

mdtoguchi approved these changes Feb 13, 2023

View reviewed changes

maksimsab changed the title ~~[SYCL] Add optimization of SYCL framework functions in Clang and -O0 LLVM Default Pipeline~~ [SYCL] Optimize SYCL framework functions with -O0 Feb 14, 2023

steffenlarsen merged commit 4f75718 into intel:sycl Feb 14, 2023

[SYCL] Optimize SYCL framework functions with -O0 #7376

[SYCL] Optimize SYCL framework functions with -O0 #7376

Uh oh!

Conversation

maksimsab commented Nov 11, 2022

Uh oh!

maksimsab commented Dec 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

premanandrao Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

maksimsab Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarnex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maksimsab commented Feb 8, 2023

Uh oh!

AlexeySachkov left a comment

Choose a reason for hiding this comment

Uh oh!

bader commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asudarsa left a comment

Choose a reason for hiding this comment

Uh oh!

maksimsab commented Feb 14, 2023

Uh oh!

Uh oh!

bader commented Feb 9, 2023 •

edited

Loading