[SYCL] Relax work-group metadata generation and processing in sycl-post-link #7471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-link When generating program metadata for reqd_work_group_size information sycl-post-link currently expects the existance of all three dimensions in the metadata. As a result the compile-time kernel property work_group_size needs to pad itself to adhere to this requirement. This commit relaxes the requirement by instead allowing fewer than three metadata operands in both reqd_work_group_size and work_group_size_hint when generating the program metadata. Additionally, padding will no longer be added when converting "sycl-work-group-size" and "sycl-work-group-size-hint" into the corresponding metadata. Signed-off-by: Larsen, Steffen <[email protected]>
|
This is in draft as it requires KhronosGroup/SPIRV-LLVM-Translator#1726 |
|
Dependency has been resolved. This is ready for review. |
Signed-off-by: Larsen, Steffen <[email protected]>
AlexeySachkov
approved these changes
Nov 28, 2022
|
Failure in Precommit is due to an infrastructure issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating program metadata for
reqd_work_group_sizeinformation sycl-post-link currently expects the existence of all three dimensions in the metadata. As a result the compile-time kernel propertywork_group_sizeneeds to pad itself to adhere to this requirement. This commit relaxes the requirement by instead allowing fewer than three metadata operands in bothreqd_work_group_sizeandwork_group_size_hintwhen generating the program metadata. Additionally, padding will no longer be added when converting "sycl-work-group-size" and "sycl-work-group-size-hint" into the corresponding metadata.