[SYCL][NFC] Fix compilation of reduction.hpp with gcc 8.4 #7484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 8.4 emits the following error:
```
include/sycl/reduction.hpp: In lambda function:
include/sycl/reduction.hpp:2318:31: error: lambda capture of ‘NumArgs’ is not a constant expression
if constexpr (NumArgs == 2) {
```
Fixed it by removing the lambda used to initialize `OneElemSize`
variable.
steffenlarsen
approved these changes
Nov 22, 2022
|
Precommit failure is an infrastructure problem. |
It very much could be the case, it is not the first time we encounter issues with older compiler, see #6892. Perhaps at some point we will claim that we only support newer gcc so we can ignore those bugs? |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Nov 22, 2022
This reverts intel#7484 and uses a less intrusive workaround for the gcc bug.
steffenlarsen
pushed a commit
that referenced
this pull request
Nov 23, 2022
AlexeySachkov
deleted the
private/asachkov/fix-reduction-header-compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 8.4 emits the following error:
Fixed it by removing the lambda used to initialize
OneElemSizevariable.