[SYCL] Fix ModuleSplitterBase::totalSplits usage #7485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ModuleSplitterBase::totalSplits` method returns the amount of _remaining_ splits, i.e. every call to `ModuleSplitterBase::nextSplit` decrements that value. Fixed an incorrect initialization of `SplitByMode` and `SplitByOptionalFeatures` variables by re-arranging code so we ask for amount of splits _before_ we extract them. Previously, those two variables were always initialized with `false`: from what I see in a code this shouldn't have resulted in any major issues, but it caused a problem in a downstream.
sarnex
reviewed
Nov 22, 2022
Renamed the method to `remainingSplits` to avoid confusion.
AlexeySachkov
deleted the
private/asachkov/fix-total-spllits-usage-in-sycl-post-link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModuleSplitterBase::totalSplitsmethod returns the amount of remaining splits, i.e. every call toModuleSplitterBase::nextSplitdecrements that value.Fixed an incorrect initialization of
SplitByModeandSplitByOptionalFeaturesvariables by re-arranging code so we ask for amount of splits before we extract them. Previously, those two variables were always initialized withfalse: from what I see in a code this shouldn't have resulted in any major issues, but it caused a problem in a downstream.