[SYCL][ESIMD]Refactor several math functions and remove duplicate constants #7490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbobrovs
reviewed
Nov 22, 2022
| @@ -1152,7 +1152,7 @@ sincos(__ESIMD_NS::simd<float, SZ> &dstcos, U src0, Sat sat = {}) { | |||
|
|
|||
| /// @cond ESIMD_DETAIL | |||
| namespace detail { | |||
| constexpr double HDR_CONST_PI = 3.1415926535897932384626433832795; | |||
| constexpr double __HDR_CONST_PI = 3.1415926535897932384626433832795; | |||
There was a problem hiding this comment.
Suggested change
| constexpr double __HDR_CONST_PI = 3.1415926535897932384626433832795; | |
| constexpr double __ESIMD_CONST_PI = 3.1415926535897932384626433832795; |
kbobrovs
reviewed
Nov 22, 2022
Comment on lines
1165
to
1167
| __ESIMD_NS::simd<float, SZ> OneP(1.f); | ||
| __ESIMD_NS::simd<float, SZ> OneN(-1.f); | ||
| __ESIMD_NS::simd<float, SZ> sign; |
There was a problem hiding this comment.
Suggested change
| __ESIMD_NS::simd<float, SZ> OneP(1.f); | |
| __ESIMD_NS::simd<float, SZ> OneN(-1.f); | |
| __ESIMD_NS::simd<float, SZ> sign; | |
| __ESIMD_NS::simd<T, SZ> OneP((T)1.f); | |
| __ESIMD_NS::simd<T, SZ> OneN((T)-1.f); | |
| __ESIMD_NS::simd<T, SZ> sign; |
kbobrovs
reviewed
Nov 22, 2022
| Result.merge(Result - T(detail::HDR_CONST_PI / 2.0), Gt1); | ||
| Result.merge(Result, Neg); | ||
| return Result; | ||
| Result.merge(Result - T(detail::__HDR_CONST_PI / 2.0), Gt1); |
There was a problem hiding this comment.
Suggested change
| Result.merge(Result - T(detail::__HDR_CONST_PI / 2.0), Gt1); | |
| Result.merge(Result - T(detail::__ESIMD_CONST_PI / T(2.0)), Gt1); |
kbobrovs
reviewed
Nov 22, 2022
v-klochkov
reviewed
Dec 1, 2022
kbobrovs
reviewed
Dec 1, 2022
| template <int N> | ||
| __ESIMD_NS::simd<float, N> atan2_fast(__ESIMD_NS::simd<float, N> y, | ||
| __ESIMD_NS::simd<float, N> x); | ||
| template <typename T, int N> |
There was a problem hiding this comment.
Not that this is an interface change. Prior to this change atan2_fast always returned float. Is this intentional?
Also applies to other APIs. Please preserve the original return types, unless there is some reason not to.
kbobrovs
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary test PR: intel/llvm-test-suite#1405