Skip to content

[SYCL][Level Zero] Use MemAdvise for read-only shared allocs #7496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

aelovikov-intel
Copy link
Contributor

Those don't affect stability:

Memory advice is a performance hint only and is not required for
functional correctness.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner November 22, 2022 20:16
@aelovikov-intel aelovikov-intel marked this pull request as draft November 22, 2022 20:29
Those don't affect stability:

 > Memory advice is a performance hint only and is not required for
 > functional correctness.
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aelovikov-intel
Copy link
Contributor Author

@intel/llvm-gatekeepers , this PR is ready.

@againull againull merged commit bf0f97e into intel:sycl Nov 23, 2022
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Nov 30, 2022
…d-only USM

There are issues in the underlying Level Zero RT causing stability
problems. This partially reverts intel#7496.
againull pushed a commit that referenced this pull request Dec 2, 2022
…d-only USM (#7601)

There are issues in the underlying Level Zero RT causing stability
problems. This partially reverts
#7496.
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Dec 12, 2022
We found some issues with this in our internal testing. Reverting until
investigation is finished.
pvchupin pushed a commit that referenced this pull request Dec 12, 2022
We found some issues with this in our internal testing. Reverting until
investigation is finished.
@aelovikov-intel aelovikov-intel deleted the usm-shared-alloc-advise branch April 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants