[SYCL][PI][L0] Upgrade L0 loader to v1.8.8 on Windows too #7552
Conversation
|
The loader cannot be newer than the runtime version in the driver (so there's no backward compatibility)? Was the same verified for the Linux driver? |
I think there is backward compatibility, but what is the reason to update loader if you are going to use features that aren't potentially supported by the Windows implementation? |
|
@jandres742 : could you comment on Windows driver support? |
I'm confused. By this reasoning what's the point of adding any new features to L0 at all? We will require drivers which are recent enough. Without this, we can't use these features at all, in any driver. Also, why is this any different on Linux? Couldn't the same reasoning by applied there as well? But the loader on Linux was updated to the most recent version regardless. |
@smaslov-intel : could you elaborate on why the cmake file specifies a specific L0 loader version? L0 loader 1.2.3 supports L0 spec 1.1, while L0 loader 1.8.8 supports spec 1.4. While they have the same major version (and no breaking in compatibility should be seen), this is a huge jump, so we need to be careful to do it. Hence my question on why we were keeping the loader for windows in 1.2.3 and if there were a specific reason, we would need to confirm that we dont break any assumptions made by SYCL. |
This commit upgrades the L0 loader version to v1.8.8 on Windows too, so the version is now the same on both Windows and Linux. The current version on Windows is very old, and it lacks important features (e.g., importing external memory from Win32 handles, compiling
ze_tracer), which blocks the Render Kit products. I haven't seen any explanation or evidence why the L0 loader has to be kept so old on Windows. I haven't encountered any issues after upgrading, including with public graphics drivers.