Skip to content

[SYCL] Add DPAS of PVC query and other improvements: #7562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Nov 28, 2022

  • Remove dynamic_p from the query since dynamic extent of the sizes is not supported
  • Add xmx16 to the list of TPUs. This is the PVC TPU
  • Change float19 to tf32
  • Extend scope to return more than one value

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Nov 28, 2022

These changes are part of the doc PR #7307

@dkhaldi dkhaldi marked this pull request as ready for review December 19, 2022 21:54
@dkhaldi dkhaldi requested a review from a team as a code owner December 19, 2022 21:54
Copy link

@mbelicki mbelicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Dec 21, 2022

@intel/llvm-reviewers-runtime, please help approve/merge this.

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Dec 22, 2022

@cperkinsintel, can you please help review/merge this?

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Dec 29, 2022

@bso-intel, can you please help review/merge this?

Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Unfortunately, I don't have merge permission. Sorry.

@bader bader changed the title Add DPAS of PVC query and other improvements: [SYCL] Add DPAS of PVC query and other improvements: Dec 29, 2022
@bader bader merged commit 8316a9c into intel:sycl Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants